AIO performance improvement by making AIOHelper persistent #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things have been pretty busy over in my neck of the woods for the last few months, and I'm trying to pick pynng back up now. I'm hoping to review this soon! Do you mind rebasing this against master so it will run with the CI that I (finally) fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each
Socketinstance is creating a newAIOHelperobject on each async operation.This PR modifies
AIOHelperto allow it to be created once atSocketinstantiation and is reused per async operation.The
AIOHelperclass creates a pair ofnng_aiocontexts (one forsend, and one forrecv), so there can be only one pending AIO operation per direction - I think this is ok, but would like feedback on this.