Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preprocess): auto fix missing webpack framework #471

Merged
merged 1 commit into from
Jan 30, 2021
Merged

fix(preprocess): auto fix missing webpack framework #471

merged 1 commit into from
Jan 30, 2021

Conversation

codymikol
Copy link
Owner

fix(preprocess): auto fix missing webpack framework

this is an issue that comes up often. As this is
something that karma-webpack needs to function,
we will automatically fix the configuration on
the fly and emit a warning that the change was
made.

Fixes N/A

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

adding 'webpack' in the karma configuration is a new requirement in v5 that is often overlooked.
as this is required and the plugin will not work without this, we will fix the configuration on the fly
and emit a warning stating that the change was made.

Breaking Changes

N/A

Additional Info

N/A

this is an issue that comes up often. As this is
something that karma-webpack needs to function,
we will automatically fix the configuration on
the fly and emit a warning that the change was
made.

Fixes N/A
@codymikol codymikol merged commit ea5dc8e into codymikol:next Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant