Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarun Lalwani/Martijn Pieters supplied fix for SNI #81

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

timkent
Copy link
Collaborator

@timkent timkent commented Oct 27, 2017

Incorporated urllib3 monkey patch fixes as per:
https://stackoverflow.com/questions/46882276/monkey-patching-ssl-wrap-socket-in-python-requests-library-isnt-executing

Appears to send correct SNI now!

Closes #67.

@timkent timkent requested a review from codingo October 27, 2017 06:31
@codingo codingo merged commit a1e888c into master Oct 27, 2017
@codingo codingo deleted the timk-sni-monkey-patch branch October 27, 2017 20:42
@codingo codingo added the bug label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPS requests working with NGINX but may have an issue with Apache
2 participants