Repository navigation
Add outbound calling ability with proper SIP BYE hang-up (dialog-centric refactor) #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 19 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
7144413
Add outbound calling ablity
codingjoe f8d7fa7
Add proper BYE hang_up to SIP sessions with dialog cleanup
Copilot c946126
Fix address
codingjoe 1d2e345
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0370426
Add ByeTransaction to acknowledge outbound BYE (RFC 3261 §17.1.2)
Copilot c834a4e
Await BYE 200 OK in hang_up() with configurable timeout (RFC 3261 §15)
Copilot 69807ed
Refactor: transactions awaitable, Dialog owns call lifecycle, dialog_…
Copilot f8c8cb3
Address code review: simplify getattr, improve BYE_ACK_TIMEOUT docstr…
Copilot 74c05f3
Refactor
codingjoe 0398663
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5a78337
Drop tests
codingjoe 5139dbf
Address review: Transaction inherits asyncio.Event, ByeTransaction bu…
Copilot 727bdcf
Fix: ByeTransaction.method defaults to SIPMethod.BYE; remove method= …
Copilot 8dfc8c6
Update docs
codingjoe 282820b
Update code
codingjoe 7e38b87
Update docs
codingjoe 14b780e
Rename
codingjoe 35110bf
Move import
codingjoe c74bd39
Refactor: Transaction→Future, symmetric send/receive, fix routing, de…
Copilot 22fb921
Fix docs
codingjoe 08169c0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 10f011b
Cleanup
codingjoe 8279155
more cleanup
codingjoe a01aa29
Fix tests: add dialog=Dialog() to Session instantiations in test_rtp.py
Copilot aeb89ce
Refactor URIs
codingjoe 67f284f
Rename
codingjoe 7f5216c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b1610c4
Support TelURI as dial target in Dialog.dial(), InviteTransaction.sen…
Copilot 0e1df3d
Convert TelURI to SipURI in InviteTransaction.send() using AOR host
Copilot bf28897
fixes
codingjoe 7010596
update docs
codingjoe 36de403
Drop tel URi
codingjoe 0b6ab37
Acknowledge all responses
codingjoe 58beb31
Fix tests
codingjoe b499392
Fix docs
codingjoe 3eaff47
Set pre-commit python version to 3.14
codingjoe 35b7fd0
Address some review comments
codingjoe c137ce4
Use correct IPs
codingjoe 7c96eb6
Fix address names
codingjoe e784760
refactor: move dialog/tx state to protocol; fix dialog tags, double A…
Copilot 016661c
fix: improve docstring and deduplicate complete() in response_received
Copilot 63c0705
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b947eed
Rename things
codingjoe acb0b12
Slim down implementation
codingjoe 92ea1bb
Fix cookbook.md examples to match current API
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| # Session Description Protocol (SDP) | ||
|
|
||
| ::: voip.sdp | ||
|
|
||
| ## Types | ||
|
|
||
| ::: voip.sdp.types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,3 @@ | ||
| # Session Initiation Protocol (SIP) | ||
|
|
||
| ::: voip.sip | ||
|
|
||
| ## Transactions | ||
|
|
||
| ::: voip.sip.transactions.InviteTransaction | ||
|
|
||
| ::: voip.sip.transactions.RegistrationTransaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.