DDF-2721: Replaced NPM with Yarn #1572
Conversation
|
Have you looked into the build failures at all? |
AzGoalie
force-pushed
the
yarn
branch
2 times, most recently
from
8f155e1 to
edfd42a
Compare
| @@ -70,8 +70,8 @@ | |||
| "webpack-merge": "0.14.0" | |||
| }, | |||
| "dependencies": { | |||
| "@turf/circle": "3.3.3", | |||
There was a problem hiding this comment.
I am concerned about potential regressions from lowering the turf version. How was this regression tested?
It looks like public scoped packages should work with Yarn.
yarnpkg/yarn#825
Maybe we can try adding the namespace to the npmrc file for this project.
yarnpkg/yarn#839
@turf:registry=http://registry.npmjs.org/
| @@ -7,7 +7,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "start": "hotreloadify src/main/webapp/js/index.js --proxy=https://localhost:8993 --open", | |||
| "pretest": "standard ./src/**/*.js", | |||
| @@ -226,18 +226,18 @@ | |||
| <artifactId>frontend-maven-plugin</artifactId> | |||
| <executions> | |||
| <execution> | |||
There was a problem hiding this comment.
I think you can remove the entire execution.
| @@ -21,7 +21,7 @@ define([ | |||
| 'terraformer', | |||
| 'terraformer-wkt-parser', | |||
| 'js/CQLUtils', | |||
| '@turf/turf', | |||
There was a problem hiding this comment.
We have some READMEs that talking about doing npm install. These should be updated.
https://github.com/codice/ddf/search?utf8=%E2%9C%93&q=%22npm+install%22&type=Code
| @@ -40,7 +40,7 @@ Automated tests can execute against a local Selenium server and target locally i | |||
| * Install and start a local Selenium server. [Webdrvr](https://www.npmjs.org/package/webdrvr) can automate this process. | |||
|
|
|||
| ``` | |||
| npm install -g webdrvr | |||
| yarn install -g webdrvr | |||
There was a problem hiding this comment.
I think you need to do yarn global add webdrvr
There was a problem hiding this comment.
It was recently deprecated, will update.
|
Passed a full build on windows. Building on linux and then will do manual verification. |
DDF-2721: Removed npm-shrinkwrap DDF-2721: Added mutex to install DDF-2721: Updated readmes DDF-2721: Updated yarn test order DDF-2721: Rolled back standard version DDF-2721: Removed unused dep and added node to catalog-ui
DDF-2721: Removed npm-shrinkwrap DDF-2721: Added mutex to install DDF-2721: Updated readmes DDF-2721: Updated yarn test order DDF-2721: Rolled back standard version DDF-2721: Removed unused dep and added node to catalog-ui
7 participants
What does this PR do?
Switches out NPM in favor of Yarn.
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@brendan-hofmann @djblue @ahoffer
Select at least one member from relevant component team(s) from below (at least one component team member needs to approve the PR).
Build
Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).
@pklinef
@stustison
How should this be tested? (List steps with links to updated documentation)
All OS: Complete build works
Windows: Quickbuild with no npm cache or yarn cache and all node_modules folders deleted is successful
Any background context you want to provide?
What are the relevant tickets?
Screenshots (if appropriate)
Checklist: