Skip to content

Updated __init__.py as for queue requirement#70

Closed
utkarsh0702 wants to merge 14 commits into
codezonediitj:masterfrom
utkarsh0702:master
Closed

Updated __init__.py as for queue requirement#70
utkarsh0702 wants to merge 14 commits into
codezonediitj:masterfrom
utkarsh0702:master

Conversation

@utkarsh0702
Copy link
Copy Markdown

Queue Implementation by Utkarsh

@czgdp1807
Copy link
Copy Markdown
Member

In ArrayQueue use, DynamicOneDimensionalArray.
Refer, the discussions at #67

@utkarsh0702
Copy link
Copy Markdown
Author

ok I will try

@utkarsh0702
Copy link
Copy Markdown
Author

I need to ask something
I had wrote the code and committed it to but the number of lines or commit or project name is not appearing on my statistics page.

@czgdp1807
Copy link
Copy Markdown
Member

From my experience, it takes around 24 hours for your contributions to reflect on the statistics page. However, feel free to contact the organizers if you are facing any issues.

@utkarsh0702
Copy link
Copy Markdown
Author

I did the necessary changes for the Dynamic One Dimensional Array but it is still showing some errors.
Can you please help me with it.

@czgdp1807
Copy link
Copy Markdown
Member

Resolve the conflicts and there are some indentation issues in your code. Once #69 is updated you will be able to see the coding pattern which you can apply in your branch.

@czgdp1807
Copy link
Copy Markdown
Member

Please give a suitable title to your PR. queue.py isn't reflecting anything reasonable.

@utkarsh0702
Copy link
Copy Markdown
Author

sir i updated the queue.py file according to the stack.py file

@utkarsh0702
Copy link
Copy Markdown
Author

sorry sir i am new to this git PR concept so i am unable to change my PR name

Comment thread pydatastructs/miscellaneous_data_structures/__init__.py Outdated
Comment thread pydatastructs/miscellaneous_data_structures/__init__.py Outdated
Comment thread pydatastructs/miscellaneous_data_structures/__init__.py
Comment thread pydatastructs/miscellaneous_data_structures/queue.py Outdated
Comment thread pydatastructs/miscellaneous_data_structures/queue.py Outdated
@czgdp1807
Copy link
Copy Markdown
Member

czgdp1807 commented Jan 1, 2020

It will be better, if rear and front are kept as data members of ArrayQueue class and updating them on every append and pop.
eidt
Press the Edit button in your browser.

@utkarsh0702 utkarsh0702 changed the title queue.py Updated queue.py file for 1d dynamic array Jan 1, 2020
@utkarsh0702
Copy link
Copy Markdown
Author

can you please check it

Comment thread pydatastructs/miscellaneous_data_structures/__init__.py
@utkarsh0702 utkarsh0702 changed the title Updated queue.py file for 1d dynamic array Updated __init__.py as for queue requirement Jan 2, 2020
@utkarsh0702
Copy link
Copy Markdown
Author

can you please check it

@czgdp1807
Copy link
Copy Markdown
Member

@utkarsh0702 Have you allowed edits from maintainers on this PR?

@utkarsh0702
Copy link
Copy Markdown
Author

I am sorry I don't know how to do it

@czgdp1807
Copy link
Copy Markdown
Member

Would you like to have your name included in the AUTHORS file? If yes then let me know your full name and email id that should be included in the file. Thanks.

@utkarsh0702
Copy link
Copy Markdown
Author

Yes, i would love too.
Name: Utkarsh Mishra
Email Id: utkarsh07022000@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants