Added enable parameter for rendering index page #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikmel2803
approved these changes
Dec 13, 2022
neSpecc
reviewed
Dec 13, 2022
| @@ -111,7 +111,10 @@ export default async function buildStatic(): Promise<void> { | |||
| await renderPage(page); | |||
| } | |||
|
|
|||
| await renderIndexPage(config.indexPageUri); | |||
| // Check if index page is enabled | |||
| if (config.indexPage.enabled) { | |||
There was a problem hiding this comment.
do not forget to add docs for the new properties.
There was a problem hiding this comment.
Sure, but for now there are no docs about static building, it is experimental feature. I think, docs about it will appear later
neSpecc
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If parameter
enabledfor index page isfalse, static fileindex.htmlwill not create