Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to copy header link #256

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Add ability to copy header link #256

merged 8 commits into from
Sep 14, 2022

Conversation

TatianaFomina
Copy link
Contributor

  • Copy link button added left to header
  • After link is copied to clipboard, success state is displayed

Task

image
image

@TatianaFomina TatianaFomina linked an issue Sep 13, 2022 that may be closed by this pull request
@slaveeks
Copy link
Member

slaveeks commented Sep 13, 2022

image

Copy button goes on the sidebar

Is it ok?

Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove the click handler (anchor, cursor pointer) from headings. Clicks should be handled only from the Copy button
  2. Copy Button -> remove bg from default styles, it should appear on hover. See new mockups
    image
  3. Reduce Copy Button border radius, paddings and position
    image
  4. Add animation to the Success State. The green block should bounce in. A light green glow should expand like a splash (use box shadow, for example, or underlayed scaled div)
    image

@TatianaFomina TatianaFomina merged commit 3e5b6a8 into main Sep 14, 2022
@TatianaFomina TatianaFomina deleted the copy-link branch September 14, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ui: update copy-link behaviour
3 participants