Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search to sidebar #215

Merged
merged 49 commits into from
Oct 13, 2022
Merged

Add search to sidebar #215

merged 49 commits into from
Oct 13, 2022

Conversation

robonetphy
Copy link
Member

resolve #175

neSpecc
neSpecc requested changes Jul 20, 2022
View reviewed changes
src/backend/views/components/sidebar.twig Outdated Show resolved Hide resolved
src/frontend/styles/components/sidebar.pcss Outdated Show resolved Hide resolved
@robonetphy robonetphy marked this pull request as draft July 20, 2022 07:28
@robonetphy robonetphy marked this pull request as ready for review July 23, 2022 19:28
@HyTekCoop HyTekCoop self-requested a review September 22, 2022 07:47
@HyTekCoop
Copy link
Member

I checked. Bugs were not found. There are a lot of comments and almost everything is clear, but of course I would like someone other than me to take a look at the code itself

HyTekCoop
HyTekCoop reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@HyTekCoop HyTekCoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth changing the keyboard shortcut for search to mac, because command + p is the functionality for printing

neSpecc
neSpecc reviewed Oct 2, 2022
View reviewed changes
src/backend/views/components/sidebar.twig Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/styles/components/sidebar.pcss Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
@neSpecc

This comment was marked as resolved.

Sign in to view
@neSpecc

This comment was marked as resolved.

Sign in to view
neSpecc
neSpecc requested changes Oct 12, 2022
View reviewed changes
src/frontend/js/classes/sidebar-filter.js Outdated Show resolved Hide resolved
src/frontend/styles/components/sidebar.pcss Show resolved Hide resolved
src/frontend/styles/components/sidebar.pcss Show resolved Hide resolved
@neSpecc

This comment was marked as resolved.

Sign in to view
@neSpecc

This comment was marked as resolved.

Sign in to view
@robonetphy robonetphy merged commit 698c09c into main Oct 13, 2022
@nikmel2803 nikmel2803 mentioned this pull request Oct 14, 2022
Closed
@nikmel2803 nikmel2803 deleted the feat/sidebar-search branch December 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyTekCoop HyTekCoop HyTekCoop approved these changes

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: implement a search
3 participants
@robonetphy @neSpecc @HyTekCoop