Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document editor styles (#180) #191

Merged
merged 10 commits into from
Jul 11, 2022
Merged

Update document editor styles (#180) #191

merged 10 commits into from
Jul 11, 2022

Conversation

Y-k-Y
Copy link
Contributor

@Y-k-Y Y-k-Y commented May 12, 2022

Resolves #180

@talyguryn
Copy link
Member

"new page" good for new pages but not for existed while editing.

image

also "put above" does not updates but it is not for this pr

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented May 24, 2022

"new page" good for new pages but not for existed while editing.

image

also "put above" does not updates but it is not for this pr

You are right. Can you suggest me the good label name pls?

@talyguryn
Copy link
Member

"new page" good for new pages but not for existed while editing.
image
also "put above" does not updates but it is not for this pr

You are right. Can you suggest me the good label name pls?

why not "parent page"?

@Y-k-Y Y-k-Y requested a review from talyguryn May 30, 2022 13:50
@Y-k-Y Y-k-Y requested a review from neSpecc June 2, 2022 15:52
neSpecc
neSpecc requested changes Jun 16, 2022
View reviewed changes
src/frontend/styles/components/writing.pcss Outdated Show resolved Hide resolved
src/frontend/styles/components/writing.pcss Outdated Show resolved Hide resolved
src/frontend/styles/components/writing.pcss Show resolved Hide resolved
@Y-k-Y Y-k-Y requested a review from neSpecc June 20, 2022 04:19
@neSpecc
Copy link
Member

neSpecc commented Jun 21, 2022

Pls, update the brunch

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jun 21, 2022

Pls, update the brunch

Fixed merge conflict

TatianaFomina
TatianaFomina reviewed Jun 23, 2022
View reviewed changes
src/frontend/styles/vars.pcss Show resolved Hide resolved
src/backend/views/pages/form.twig Outdated Show resolved Hide resolved
src/frontend/styles/components/writing.pcss Show resolved Hide resolved
robonetphy
robonetphy requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@robonetphy robonetphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word is cutting a little bit
image.
I guess you need to add line-height:18px

src/frontend/styles/vars.pcss Outdated Show resolved Hide resolved
@Y-k-Y Y-k-Y requested a review from robonetphy July 8, 2022 11:09
robonetphy
robonetphy requested changes Jul 8, 2022
View reviewed changes
Copy link
Member

@robonetphy robonetphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Pls do the line-height change with input too

@Y-k-Y Y-k-Y requested a review from robonetphy July 9, 2022 00:30
neSpecc
neSpecc approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with input height and icon sizes. But I'd suggest to resolve them via the next PRs, becuase I want to change mockups and use CodeX Icon Pack there

@Y-k-Y Y-k-Y merged commit 69b61a2 into main Jul 11, 2022
@Y-k-Y Y-k-Y deleted the feature/new-editor-form branch July 11, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TatianaFomina TatianaFomina TatianaFomina left review comments

@neSpecc neSpecc neSpecc approved these changes

@talyguryn talyguryn talyguryn approved these changes

@robonetphy robonetphy robonetphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: update document editor styles
5 participants
@Y-k-Y @talyguryn @neSpecc @robonetphy @TatianaFomina