Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project logo at the bottom of aside #190

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

Y-k-Y
Copy link
Contributor

@Y-k-Y Y-k-Y commented May 11, 2022

Resolves #182

@talyguryn
Copy link
Member

not aligned vertically. is it ok?

image

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented May 24, 2022

not aligned vertically. is it ok?

image

It's aligned vertically i set the align-items: center property to it.
image

Does it look unaligned?

@Y-k-Y Y-k-Y requested a review from talyguryn May 30, 2022 13:50
@talyguryn
Copy link
Member

well i see but cause bottom padding of image it looks moved up. need to ask design department to check it

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jun 1, 2022

well i see but cause bottom padding of image it looks moved up. need to ask design department to check it

@talyguryn The logo was 2px upper than text so i set the logo wrapper as inline-flex now it looks perfectly aligned 👍

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jun 1, 2022

Surprised you can catch that little alignment difference!

@Y-k-Y Y-k-Y merged commit 16ba86f into main Jun 2, 2022
@Y-k-Y Y-k-Y deleted the feature/aside-project-logo branch June 2, 2022 15:01
@robonetphy
Copy link
Member

@Y-k-Y you should wait for at least two approval

@Y-k-Y
Copy link
Contributor Author

Y-k-Y commented Jun 3, 2022

@Y-k-Y you should wait for at least two approval

🫢 can i rollback merged pr?

@talyguryn
Copy link
Member

don't worry, but be patient next time 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: add a project logo
3 participants