Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asyncstatemachine): fixes not awaiting or asyncSpawning futures #1025

Open
wants to merge 1 commit into
base: fix/fix-async-futures/remove-then-from-trackedfutures
Choose a base branch
from
Open

fix(asyncstatemachine): fixes not awaiting or asyncSpawning futures #1025

wants to merge 1 commit into from
+27 −31

Conversation

emizzle
Copy link
Contributor

@emizzle emizzle commented Dec 9, 2024

  • adds a break in scheduler when CancelledError is caught
  • tracks asyncSpawned state.run, so that it can be cancelled during stop
  • removes usages of then
  • ensures that no exceptions are leaked from async procs

Notes

@emizzle
fix(asyncstatemachine): fixes not awaiting or asyncSpawning futures
ea8e71d 
- adds a break in scheduler when CancelledError is caught
- tracks asyncSpawned state.run, so that it can be cancelled during stop
- removes usages of `then`
- ensures that no exceptions are leaked from async procs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emizzle