Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codex-release-tests workflow #108

Closed
veaceslavdoina opened this issue Nov 26, 2024 · 4 comments
Closed

Add codex-release-tests workflow #108

veaceslavdoina opened this issue Nov 26, 2024 · 4 comments
Assignees
Labels
E:Distributed Client Testing See [insert issue/discussion] for details

Comments

@veaceslavdoina
Copy link
Contributor

veaceslavdoina commented Nov 26, 2024

@benbierens already started to implement run-codex-release-tests.yaml which is planed to be used to test Codex pre-releases images check in a single click.

  • The workflow should start dotnet test ./Tests/CodexReleaseTests
  • The workflow should show the normal console output for this run
  • It's OK if the workflow takes a long time.

The goal is to give a push-button solution so anyone can run the "release required" dist-tests for a codex image.

We already have some workflows implemented and a Docker image with a custom docker-entrypoint.sh. It would be good to adjust and reuse it.

Also, we should add basic documentation how to use it.

@veaceslavdoina veaceslavdoina added the E:Distributed Client Testing See [insert issue/discussion] for details label Nov 26, 2024
@veaceslavdoina veaceslavdoina self-assigned this Nov 26, 2024
@benbierens
Copy link
Contributor

Branch "feature/release-tests-cleanup"

Previously "CodexTests" are now split into

"CodexReleaseTests" - Anyone should be able to run these on any Codex dist-test docker image. These tests should reliably pass for any future release of Codex. These tests will be updated and extended as Codex changes.

"ExperimentalTests" - I use these to diagnose issues and help track down bugs. These tests do not reliably pass and they don't need to.

"FrameworkTests" - Tests for the testing framework.

"CodexContinuousTests" and "CodexTestsLong" have not been changed for a while.

@veaceslavdoina
Copy link
Contributor Author

Thanks, so we do not have anymore just dist-tests and I will clean-up the stuff we have for them.

@veaceslavdoina
Copy link
Contributor Author

Single button was implemented and we can test it after some tests will be updated - Run Release Tests.

Image

@veaceslavdoina
Copy link
Contributor Author

veaceslavdoina added a commit to codex-storage/nim-codex that referenced this issue Dec 3, 2024
github-merge-queue bot pushed a commit to codex-storage/nim-codex that referenced this issue Dec 4, 2024
* Refactor Docker reusable workflow and add release tests support

codex-storage/cs-codex-dist-tests#108

* Add an option to run release tests for Docker images

codex-storage/cs-codex-dist-tests#108

* Use bigger instance for arm builds

codex-storage/cs-codex-dist-tests#108

* Pass repository and branch to release tests workflow

codex-storage/cs-codex-dist-tests#108

* Do not use computation job because run_release_tests is a string

codex-storage/cs-codex-dist-tests#108
veaceslavdoina added a commit to codex-storage/nim-codex that referenced this issue Dec 4, 2024
github-merge-queue bot pushed a commit to codex-storage/nim-codex that referenced this issue Dec 4, 2024
* Refactor Docker reusable workflow and add release tests support

codex-storage/cs-codex-dist-tests#108

* Add an option to run release tests for Docker images

codex-storage/cs-codex-dist-tests#108

* Use bigger instance for arm builds

codex-storage/cs-codex-dist-tests#108

* Pass repository and branch to release tests workflow

codex-storage/cs-codex-dist-tests#108

* Do not use computation job because run_release_tests is a string

codex-storage/cs-codex-dist-tests#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Distributed Client Testing See [insert issue/discussion] for details
Projects
None yet
Development

No branches or pull requests

2 participants