Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Editor for AssetImporter and ScriptedImported #112

Merged
merged 2 commits into from
May 9, 2023
Merged

Implement Editor for AssetImporter and ScriptedImported #112

merged 2 commits into from
May 9, 2023

Conversation

xarpen
Copy link
Contributor

@xarpen xarpen commented May 7, 2023

Hi, this add support for AssetImporterEditor and ScriptedImporterEditor.
I've just botch copied your code for now, if you have a better idea I'm happy to split the code to some static class or something.

@vanifatovvlad
Copy link
Contributor

Hi @xarpen , thanks for contribution!
Can you describe why you omitted the isFallback property and AllowEditorMultipleObjects attribute that are present for regular editors?
Can you also provide here small examples of how to use these new editors?

@xarpen
Copy link
Contributor Author

xarpen commented May 9, 2023

Hi, I've reverted the AllowEditorMultipleObjects, it was removed by mistake when I was trying to understand why it would not show. It seems for whatever reason (and I didn't not look thoroughly) that when you have isFallback=true it picks some other inspector for default, and does not show nicely.

I've created a "native" importer for Vox format which I plan to publish to Github soon.
I use your plugin to improve Inspector visibility of the ScriptedImporter.

Second importer I think is for when you want to override default AssetImporter to do some custom pre-post importing logic (like change the texture max size by the content).
I don't really use it right now, and I can remove it from PR if you think there would be no use for it in future.

image

@vanifatovvlad vanifatovvlad merged commit 04ad48a into codewriter-packages:main May 9, 2023
@xarpen xarpen deleted the feature/importers branch May 9, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants