Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default behaviour to ignore archived and deleted repos #1743

Merged
merged 7 commits into from
Oct 28, 2023
Merged

Changes default behaviour to ignore archived and deleted repos #1743

merged 7 commits into from
Oct 28, 2023

Conversation

hbontempo-br
Copy link
Contributor

Description

Changes default behavior of ReposModel to deleted and archived repos.
This repos are going to remain on database but should be ignored everywhere in the application

Related Issue

Related to #1704
Should deal with #1735 / #1545

Motivation and Context

Should prevent "bad" repos to be presented to users

How Has This Been Tested?

Automated tests + rubocop analysis (locally)

Screenshots (if appropriate):

--

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change out default_scope for something else.

app/models/repo.rb Outdated Show resolved Hide resolved
@hbontempo-br
Copy link
Contributor Author

PR ended up being bigger than originally expected.
Could break up into smaller ones if you prefer.

@schneems
Copy link
Member

Thanks for working on this. Sorry for the EXTREME delay. Looks great. I corrected a merge conflict. re-running tests now.

@schneems schneems merged commit e540621 into codetriage:main Oct 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants