support --ignore-words-case-sensitive option.
#3658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
commented
Mar 2, 2025
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@DimitriPapadopoulos what do you think about this?
- this PR keeps the current default behavior so no downstream packages are affected.
- fix the documentation aligned with current implementation in default.
- add
--ignore-words-case-sensitiveoption, to ignore all words in a case-sensitive manner. this give more flexibility for user.
Author
|
@larsoner @peternewman could you guide me to proceed this PR? |
Author
|
@DimitriPapadopoulos friendly ping 🙇 |
Author
|
Hi maintainers, is there anything i can do on my side, nobody is responding at all... trying to get some attention here. |
Author
|
@DimitriPapadopoulos could you please guide me how to get review for this PR? |
Author
|
@larsoner @peternewman @DimitriPapadopoulos friendly ping, please. |
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
force-pushed
the
ignore-words-case-sensitive-option
branch
from
89240dc to
de9a5db
Compare
Author
|
@DimitriPapadopoulos friendly ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3638