-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word in ignore-words file not ignored. #2137
Comments
Interesting - it seems to be related to the casing, probably the same problem as #2026 Sounds like word lists and letter case isn't working as documented? |
So that line in our dictionary/word list doesn't seem to have changed for ages:
This timeline doesn't quite seem to match what I can see in your commits... It looks like you added the ACn word here: The check after has the error: The check before doesn't (obviously): From the usage section:
We've had a few recent PRs to try and clarify this further, but please let us know if you've got any further suggestions to improve the wording of that help info. |
* fixed missed closing of a dataset * fixed missed closing of a dataset * fixed typo in error return * Committing clang-format changes * minor edits * code format * Committing clang-format changes * code format * minor edit * switched from using MPI_count, to actual bytes written for H5FD_mpio_debug rw debugging * Committing clang-format changes * changed size_i in printf to reflect the I/O. * Committing clang-format changes * Fixed seg fault with xlf on BE with -qintsize=8 * fixed error function string * spelling corrections via codespell, added new spell check github actions * Committing clang-format changes * misc * misc * misc * misc * misc * misc * misc * misc * misc * misc * misc * misc * misc * misc * Committing clang-format changes * misc * misc * misc * misc * misc * misc * Committing clang-format changes * misc * work around for codespell-project/codespell#2137 * misc * added missing file * misc * misc. * misc * switch to using Codespell with GitHub Actions * misc. * misc. * fixed more sp errors * Fix new typos found by codespell. * fixed proceed with precede * fixed variable in fortran test * fixed minnum * updated spelling list Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Larry Knox <[email protected]>
I've run into this issue as well and I also didn't understand the note (although I read it multiple times):
I'd like to suggest the following:
|
In terms of what would actually be the most useful for the stated goal of spell-checking code.... I would argue that that even if the base dictionary is not case sensitive, it'd be nice if the exceptions were.... Like, "acn" is totally a misspelling in my application, whereas "ACn" is the only correct way (as endorsed by the manufacturer of the hardware we're working with) to refer to "any of the AC peripherals" which they call AC0, AC1, AC2 and so on.... Similarly, "systen" would, almost anywhere, be a misspelling of "system", whereas "SYSten" might well be correct in some codebases along with "SYSone" through "SYSnine".... Much more so than with normal language, code has lots of things where the capitalization makes the difference between a normal word and an abbreviation..... |
I agree with @SpenceKonde, but I think that should be a new issue. |
In my open source projects,
ACn
a correct abbreviation (for one of the analog comparators on the chip, which are named AC0, AC1, etc)Of course codespell objected to it, I added it to my ignore words list and all had been well.
Until a few weeks ago.
Now that specific entry in the ignorewords file is non-functional: It does not cause "ACn" to be ignored. Other lines still work, just not that one. I've tried moving it around in the file, but that has not made a difference. My repos now fail spellchecking, and I don't know what changed or how to fix it.
The only thing that seems to be different is that this is a 3 letter word (4 and 5 letter words seem to work)
Happens in github actions and reproduces on my local machine with:
codespell --check-filenames --check-hidden --skip ./.git,.py,.gif,.jpg,.png --ignore-words megaavr/extras/ci/codespell-ignore-words-list.txt
The text was updated successfully, but these errors were encountered: