Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

README update documenting the use of containers #4

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

mattetti
Copy link
Contributor

@mattetti mattetti commented Jun 9, 2020

This PR documents how one can use VSCode + Docker to run this codespace locally.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a whole bunch! 🎉 Besides some small nits, the only thing I want to clarify is rust-lang.rust extension vs rust-analyzer.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -4,7 +4,8 @@
"ms-vsliveshare.vsliveshare",
"matklad.rust-analyzer",
"serayuzgur.crates",
"vadimcn.vscode-lldb"
"vadimcn.vscode-lldb",
"rust-lang.rust"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension provides the same functionality as rust-analyzer so we don't need to include both. rust-analyzer is, in my opinion, much more stable than the rust-lang.rust extension, and in fact, the plan is to replace the rust-lang.rust extension with rust-analyzer at some point. rust-analyzer should prompt automatically for you to install the executable needed, and then it should just work ™. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matklad.rust-analyzer didn't work out of the box, at least not for me. Intellisense wasn't working, it wasn't compiling on save etc... I can try to dig further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I gave it another try and noticed that there is indeed a popup asking you to install the language server, I missed it the first time around. I wonder if there's a way to have that installed by default?

devcontainer_json_—_rust-codespace__Dev_Container__Codespaces_Rust_Starter_

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could install the binary for the user. But I think we need to first figure out where the binary is installed to

@mattetti
Copy link
Contributor Author

PR updated with the requested changes, I learned a lot through this process.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉Thanks again!

@rylev rylev merged commit 3c8fafb into codespaces-examples:master Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants