-
Notifications
You must be signed in to change notification settings - Fork 130
README update documenting the use of containers #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a whole bunch! 🎉 Besides some small nits, the only thing I want to clarify is rust-lang.rust
extension vs rust-analyzer
.
.devcontainer/devcontainer.json
Outdated
@@ -4,7 +4,8 @@ | |||
"ms-vsliveshare.vsliveshare", | |||
"matklad.rust-analyzer", | |||
"serayuzgur.crates", | |||
"vadimcn.vscode-lldb" | |||
"vadimcn.vscode-lldb", | |||
"rust-lang.rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extension provides the same functionality as rust-analyzer so we don't need to include both. rust-analyzer is, in my opinion, much more stable than the rust-lang.rust extension, and in fact, the plan is to replace the rust-lang.rust extension with rust-analyzer at some point. rust-analyzer should prompt automatically for you to install the executable needed, and then it should just work ™. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matklad.rust-analyzer
didn't work out of the box, at least not for me. Intellisense wasn't working, it wasn't compiling on save etc... I can try to dig further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could install the binary for the user. But I think we need to first figure out where the binary is installed to
PR updated with the requested changes, I learned a lot through this process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉Thanks again!
This PR documents how one can use VSCode + Docker to run this codespace locally.