-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proxy support #87
Conversation
b6e9357
to
0d521b1
Compare
0d521b1
to
3371d25
Compare
Does this support username+password? Also this is HTTP proxy only? |
this proxy is for http client only, doesn't support username/pass but I can try to add it @vans163 . |
@antonioua can we use SOCKS5 proxy as well? not exactly sure if used http client would work with them |
yep, tested socks5 and http - both works.
|
saw another PR master...mariotrucco:78-add-proxy-support for proxy support, that one assumes it can only be a http proxy, but otherwise looks reasonable as well |
Yea I think its important to have user/pass auth for both http and socks5 proxy as most paid proxies use that. Free/open/tor proxies dont but those are very few. Note: HTTP Auth can be done like |
bombardier.go
Outdated
@@ -441,6 +441,8 @@ func (b *bombardier) disableOutput() { | |||
} | |||
|
|||
func main() { | |||
proxyServer = os.Getenv("BOMBARDIER_PROXY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably come from a command line argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
added proxy http/socks5 support for both http and fasthttp clients |
Add proxy support for http client