-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add disable keep alives #47
Feature/add disable keep alives #47
Conversation
Bump commit date for v1.2 tag, so that people don't get confused about which version is latest as seen in codesenberg#36.
…Alives) * It is only compatible with --http1 and --http2 (not with fasthttp) * Add `disableKeepAlives` (boolean) to args_parser.go and config.go * Set parameter to clientOpts (bombardier.go) * Configure http client transport with `DisableKeepAlives` (clients.go)
…sable-keep-alives # Conflicts: # args_parser.go
Thanks, @fulldump. Very cool. |
@@ -108,6 +109,10 @@ func newKingpinParser() argsParser { | |||
" chain and host name"). | |||
Short('k'). | |||
BoolVar(&kparser.insecure) | |||
app.Flag("disableKeepAlives", | |||
"Disable HTTP KeepAlive"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should also mention that for fasthttp
a header needs to be set. See here.
Something like "Disable HTTP keep-alive. For fasthttp also set -H 'Connection: close'".
Shame this PR was stale for more than a year and small tweaks preventing it from being merged weren't resolved, but I added this functionality anyway. Wish there was some way to give you credit, but thanks for PR anyways 👍 |
No worries at all, it is my bad. Btw, I still use bombardier whenever I need to test servers performance, it is a great tool! |
feat: Add parameter to disable HTTP keep alives (-a and --disableKeepAlives)