Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Host' Header cannot be set #41

Closed
nielsole opened this issue Oct 18, 2018 · 2 comments
Closed

'Host' Header cannot be set #41

nielsole opened this issue Oct 18, 2018 · 2 comments
Assignees
@codesenberg
Labels
enhancement
Milestone
v1.2.1

Comments

@nielsole
Copy link

What version of bombardier are you using?

v1.2

What operating system and processor architecture are you using (if relevant)?

linux/amd64

What did you do?

I need to send a custom Host header. E.g.

bombardier http://localhost:8000  -l -o json -p r -c 1 --header="Host: somethingelse" -d 2s

What you expected to happen?

Request 'Host' header would be replaced with my cusotm header

What actually happened?

The Hostname from the URI was taken into the Host header field.

This has been discussed upstream:
valyala/fasthttp#318
codesenberg added a commit that referenced this issue Oct 20, 2018
@codesenberg
clients.go: change implementation to send Host header correctly
4f53abf 
Turns out there is a way to send Host header correctly with fasthttp.
This commit also adds a bunch of tests to improve coverage.

Updates #41.
@codesenberg
Copy link
Owner

@nielsole, thanks for pointing out that there is a way to send Host header correctly with fasthttp. I pushed the fix to the host-header branch. See if it works as expected now and then I can merge it.

@codesenberg codesenberg self-assigned this Oct 20, 2018
@codesenberg codesenberg added this to the v1.2.1 milestone Oct 20, 2018
codesenberg added a commit that referenced this issue Dec 18, 2018
@codesenberg
clients.go: change implementation to send Host header correctly
4b1b549 
Turns out there is a way to send Host header correctly with fasthttp.
This commit also adds a bunch of tests to improve coverage.

Updates #41.
@codesenberg
Copy link
Owner

Closing, but feel free to reopen.

codesenberg added a commit that referenced this issue Dec 18, 2018
@codesenberg
clients.go: change implementation to send Host header correctly
6491a5d 
Turns out there is a way to send Host header correctly with fasthttp.
This commit also adds a bunch of tests to improve coverage.

Updates #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codesenberg codesenberg

Labels
enhancement
Projects
None yet
Milestone
v1.2.1
Development

No branches or pull requests
2 participants
@codesenberg @nielsole