Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory details to the package.json of all packages #54

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jul 15, 2019

Just like codesandbox/codesandbox-client#2167

Specifying the directory as part of the repository field in a package.json allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package.

This format was accepted by npm in npm/rfcs#19.

@MichaelDeBoey MichaelDeBoey force-pushed the add-repository-directory branch from 1c94601 to a842a8e Compare July 18, 2019 10:14
@MichaelDeBoey
Copy link
Contributor Author

Ping @Noviny

Copy link

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Noviny Noviny merged commit ed96d93 into codesandbox:master Sep 10, 2019
@MichaelDeBoey MichaelDeBoey deleted the add-repository-directory branch September 10, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants