Issue 9 configure google calendar integration #43

Ninjawarrior69 · 2025-11-29T03:03:34Z

Change Summary
Added Google Calendar integration for CRUD operations.
Created helper functions (create_event, get_event, update_event, delete_event) in events.py.
Added client.py to handle service account authentication.
Added pytest for CRUD operations using personal Google API credentials

Change Form
The pull request title has an issue number — Yes
The change works by "Smoke testing" or quick testing — ran mocked CRUD tests, all passed
The change has tests — yes
The change has documentation — yes

Other Information
.env.example updated with placeholders for GOOGLE_CREDENTIALS_FILE and GOOGLE_CALENDAR_ID.

This reverts commit a13dd93.

…emplate

…al calendar

ErikaKK · 2025-12-02T15:34:55Z

server/.env.example

+# Google API
+GOOGLE_CREDENTIALS_FILE=server/api/booking/google_calendar/template_service_account.json
+GOOGLE_CALENDAR_ID=xxxx
+AWS_ACCESS_KEY_ID=xxxx


Please remove aws related variables

ErikaKK · 2025-12-02T15:40:57Z

server/api/booking/google_calendar/events.py

+CALENDAR_ID = os.getenv("GOOGLE_CALENDAR_ID")
+
+
+def create_event(event_data: dict):


please add docs for event_data's key

ErikaKK · 2025-12-02T16:05:34Z

server/api/booking/google_calendar/test_google_calendar.py

this test fails when you don't set the environment variables so need to fix it

…ndency on env vars need to be set in test file

Copilot

Pull request overview

This PR adds Google Calendar integration functionality to support CRUD operations on calendar events. The implementation uses service account authentication and provides helper functions for creating, reading, updating, and deleting events.

Key Changes

Added google-api-python-client dependency and related packages
Created helper functions (create_event, get_event, update_event, delete_event) in events.py
Implemented service account authentication in client.py
Added integration tests with environment variable gating

Reviewed changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
server/pyproject.toml	Added google-api-python-client dependency
server/poetry.lock	Updated lock file with new dependencies and version updates
server/api/booking/google_calendar/test_google_calendar.py	Added integration test for CRUD operations
server/api/booking/google_calendar/events.py	Implemented calendar event CRUD helper functions
server/api/booking/google_calendar/client.py	Created service account authentication handler
server/api/booking/google_calendar/template_service_account.json	Added template for service account credentials
server/api/booking/google_calendar/init.py	Created empty module init file
server/.env.example	Added Google Calendar configuration placeholders
.gitignore	Added actual service account credentials file to ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T09:57:49Z

server/api/booking/google_calendar/client.py

+def get_calendar_service():
+
+    if not cred_path:
+        raise FileNotFoundError(


Using FileNotFoundError is misleading here. The error is raised when the environment variable is not set, not when a file is not found. The file might exist but the environment variable is simply missing. Consider using ValueError or a custom exception instead, as this is a configuration error.

Suggested change

raise FileNotFoundError(

raise ValueError(

Copilot · 2025-12-03T09:57:50Z

server/api/booking/google_calendar/events.py

+    if not CALENDAR_ID:
+        raise ValueError(
+            "GOOGLE_CALENDAR_ID is missing. Set it in your environment.")


The CALENDAR_ID validation check is duplicated across all four functions (lines 30, 48, 66, 83). Consider extracting this validation into a helper function or decorator to reduce code duplication and improve maintainability.

Copilot · 2025-12-03T09:57:50Z

server/api/booking/google_calendar/test_google_calendar.py

+            "dateTime": "2025-12-2T15:00:00",
+            "timeZone": "Australia/Perth",
+        },
+        "end": {
+            "dateTime": "2025-12-2T16:00:00",


The date format in the test is invalid. ISO 8601 format requires two-digit day values. The date "2025-12-2" should be "2025-12-02". This applies to both the start and end dateTime fields.

Suggested change

"dateTime": "2025-12-2T15:00:00",

"timeZone": "Australia/Perth",

},

"end": {

"dateTime": "2025-12-2T16:00:00",

"dateTime": "2025-12-02T15:00:00",

"timeZone": "Australia/Perth",

},

"end": {

"dateTime": "2025-12-02T16:00:00",

Copilot · 2025-12-03T09:57:50Z

server/api/booking/google_calendar/client.py

+cred_path = os.getenv("GOOGLE_CREDENTIALS_FILE")
+calendar_id = os.getenv("GOOGLE_CALENDAR_ID")
+
+
+def get_calendar_service():


Environment variables are being read at module import time (line 13-14), which means they are loaded once when the module is first imported. This can cause issues in testing scenarios or when environment variables change during runtime. Consider moving these reads inside the get_calendar_service() function or making them lazy-loaded.

Suggested change

cred_path = os.getenv("GOOGLE_CREDENTIALS_FILE")

calendar_id = os.getenv("GOOGLE_CALENDAR_ID")

def get_calendar_service():

def get_calendar_service():

cred_path = os.getenv("GOOGLE_CREDENTIALS_FILE")

calendar_id = os.getenv("GOOGLE_CALENDAR_ID")

Copilot · 2025-12-03T09:57:51Z

server/api/booking/google_calendar/events.py

+import os
+from .client import get_calendar_service
+
+CALENDAR_ID = os.getenv("GOOGLE_CALENDAR_ID")


The CALENDAR_ID is loaded at module import time, which means it's evaluated once when the module is first imported. This can cause issues in testing environments or when environment variables change. Consider loading it inside each function or using a lazy-loading pattern.

Copilot · 2025-12-03T09:57:51Z

server/pyproject.toml

Unnecessary blank line added. This creates an inconsistent spacing pattern in the dependencies section.

Suggested change

Copilot · 2025-12-03T09:57:51Z

server/.env.example

+GOOGLE_CREDENTIALS_FILE=server/api/booking/google_calendar/template_service_account.json
+GOOGLE_CALENDAR_ID=xxxx
+
+


Unnecessary blank line added at the end of the Google API section.

Suggested change

Copilot · 2025-12-03T09:57:52Z

server/api/booking/google_calendar/test_google_calendar.py

+            "dateTime": "2025-12-2T15:00:00",
+            "timeZone": "Australia/Perth",
+        },
+        "end": {
+            "dateTime": "2025-12-2T16:00:00",


The date format in the test is invalid. ISO 8601 format requires two-digit day values. The date "2025-12-2" should be "2025-12-02".

Suggested change

"dateTime": "2025-12-2T15:00:00",

"timeZone": "Australia/Perth",

},

"end": {

"dateTime": "2025-12-2T16:00:00",

"dateTime": "2025-12-02T15:00:00",

"timeZone": "Australia/Perth",

},

"end": {

"dateTime": "2025-12-02T16:00:00",

Copilot · 2025-12-03T09:57:52Z

server/api/booking/google_calendar/client.py

+load_dotenv(os.path.join(BASE_DIR, ".env"))
+
+cred_path = os.getenv("GOOGLE_CREDENTIALS_FILE")
+calendar_id = os.getenv("GOOGLE_CALENDAR_ID")


The calendar_id variable is retrieved but never used in this module. Consider removing it to avoid confusion.

Suggested change

calendar_id = os.getenv("GOOGLE_CALENDAR_ID")

Ninjawarrior69 force-pushed the issue-9-Configure_google_calendar_integration branch from d8052b3 to 0b7d4a0 Compare November 29, 2025 03:33

ErikaKK linked an issue Dec 1, 2025 that may be closed by this pull request

Configure google calendar integration #9

Open

Ninjawarrior69 added 9 commits December 2, 2025 02:39

added google api python client package

a01d002

added google api key template and CRUD for events

108e818

Revert "added google api key template and CRUD for events"

e60a240

This reverts commit a13dd93.

Redownload google api python client package and add google api .env t…

cdf4d14

…emplate

added crud for events and test file

ad19067

poetry update

3f66aaf

poetry.lock new file

7e72f9d

Updated the google calendar test file plus client.py. Works on person…

143a396

…al calendar

fix back code check issue and updated cleint.py

05f0bea

Ninjawarrior69 force-pushed the issue-9-Configure_google_calendar_integration branch from b189071 to 05f0bea Compare December 2, 2025 02:44

ErikaKK reviewed Dec 2, 2025

View reviewed changes

Ninjawarrior69 added 2 commits December 3, 2025 09:34

remove duplicate aws variables, added docs to events and removed depe…

9a5edae

…ndency on env vars need to be set in test file

fix google creds file error

9be90f6

ErikaKK requested a review from Copilot December 3, 2025 09:50

Copilot started reviewing on behalf of ErikaKK December 3, 2025 09:50 View session

Copilot finished reviewing on behalf of ErikaKK December 3, 2025 09:55

Copilot AI reviewed Dec 3, 2025

View reviewed changes

implement copilot changes

9a27950

		CALENDAR_ID = os.getenv("GOOGLE_CALENDAR_ID")


		def create_event(event_data: dict):

		GOOGLE_CREDENTIALS_FILE=server/api/booking/google_calendar/template_service_account.json
		GOOGLE_CALENDAR_ID=xxxx

Issue 9 configure google calendar integration #43

Are you sure you want to change the base?

Issue 9 configure google calendar integration #43

Uh oh!

Conversation

Ninjawarrior69 commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ErikaKK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Ninjawarrior69 Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

ErikaKK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Ninjawarrior69 Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

ErikaKK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Ninjawarrior69 Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ninjawarrior69 commented Nov 29, 2025 •

edited

Loading