Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should type definition files be used? #56

Closed
sakamossan opened this issue Jul 13, 2023 · 2 comments · Fixed by #57
Closed

How should type definition files be used? #56

sakamossan opened this issue Jul 13, 2023 · 2 comments · Fixed by #57
Assignees
Labels
bug A confirmed bug

Comments

@sakamossan
Copy link
Contributor

I tried to use the type definition files because there is a types directory, but the types directory and its contents are not included in the npm package (fetched by npm install). Additionally, the type definition files are also not included in the GitHub releases. It doesn't seem to be specified in the .npmignore file, but how are the type definition files intended to be used and committed?

when I directly run tsc on types/simple-mask-money.d.ts, there are some compilation errors. It seems that some modifications are necessary to use it with the latest version of TypeScript.

$ tsc --version
Version 5.1.6
$ tsc ./types/simple-mask-money.d.ts | grep -oP error.+ | sort | uniq -c
   5 error TS1070: 'public' modifier cannot appear on a type member.
   6 error TS1246: An interface property cannot have an initializer.

ref

@codermarcos codermarcos self-assigned this Aug 17, 2023
@codermarcos codermarcos added the bug A confirmed bug label Aug 17, 2023
@codermarcos
Copy link
Owner

@sakamossan Sorry about that 💔! You are right it is a problem!
I will work in a new version probably next week! My plan is re-write all the package improve the code and the performance as well.
But If you really need to adjust the typing, please feel free to contribute, it will help a lot ❤️

sakamossan added a commit to sakamossan/simple-mask-money that referenced this issue Aug 18, 2023
@sakamossan
Copy link
Contributor Author

Thank you for your response. I've created a pull request.

codermarcos added a commit that referenced this issue Aug 21, 2023
@codermarcos codermarcos moved this to Done in Tasks Sep 25, 2023
codermarcos pushed a commit that referenced this issue Aug 23, 2024
codermarcos added a commit that referenced this issue Aug 23, 2024
codermarcos pushed a commit that referenced this issue Aug 23, 2024
codermarcos added a commit that referenced this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants