SANDBOX-559 K8s 1 27 member#551
Conversation
ranakan19
requested review from
MatousJobanek,
alexeykazakov,
mfrancisc,
rajivnathan,
sbryzak and
xcoulon
as code owners
| cl := http.Client{} | ||
|
|
||
| err := wait.Poll(DefaultRetryInterval, DefaultTimeout, func() (done bool, err error) { | ||
| err := wait.PollUntilContextTimeout(context.TODO(), DefaultRetryInterval, DefaultTimeout, false, func(ctx context.Context) (done bool, err error) { |
There was a problem hiding this comment.
Poll is being deprecated and the linter was complaining. However to fix this there was a typo in the function name that was suggested as replacement, which was later fixed.
PTAL here if the context is used correctly - I'm not a 100% sure.
For reference please check - https://github.com/kubernetes/apimachinery/issues/153 and the fix here - https://github.com/kubernetes/kubernetes/pull/117143/files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #551 +/- ##
==========================================
- Coverage 82.30% 82.17% -0.13%
==========================================
Files 28 28
Lines 3243 3243
==========================================
- Hits 2669 2665 -4
- Misses 434 437 +3
- Partials 140 141 +1
|
|
MatousJobanek
left a comment
MatousJobanek
left a comment
There was a problem hiding this comment.
Looks good, but I have a few comments on the versions in go.mod file.
Also, is there a reason why you picked the v0.27.2 specifically, and not the latest v0.27.x patch version that is available at the time when we are doing the update? This is just a detail since we are going to bump the version to the next minor one soon again.
| k8s.io/klog v1.0.0 | ||
| k8s.io/klog/v2 v2.70.1 | ||
| k8s.io/klog/v2 v2.90.1 | ||
| k8s.io/metrics v0.25.0 |
There was a problem hiding this comment.
why isn't this dependency k8s.io/metrics updated to v0.27.2 as well?
| github.com/prometheus/client_golang v1.15.1 | ||
| k8s.io/apiextensions-apiserver v0.27.2 | ||
| k8s.io/apimachinery v0.27.2 | ||
| k8s.io/kubectl v0.24.0 |
There was a problem hiding this comment.
the same - it should use
| k8s.io/kubectl v0.24.0 | |
| k8s.io/kubectl v0.27.2 |
| github.com/go-logr/logr v1.2.3 | ||
| github.com/go-logr/logr v1.2.4 | ||
| github.com/google/go-cmp v0.5.9 | ||
| // using latest commit from 'github.com/openshift/api branch release-4.12' |
There was a problem hiding this comment.
| // using latest commit from 'github.com/openshift/api branch release-4.12' | |
| // using latest commit from 'github.com/openshift/api branch release-4.14' |
| github.com/openshift/api v0.0.0-20230213134911-7ba313770556 | ||
| github.com/openshift/api v0.0.0-20231117205818-971e4ba78c9a | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/redhat-cop/operator-utils v1.3.3-0.20220121120056-862ef22b8cdf |
There was a problem hiding this comment.
let's update this dependency as well to match the version of k8s v.0.27.x - it should be the version v1.3.6 https://github.com/redhat-cop/operator-utils/releases/tag/v1.3.6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, ranakan19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment was marked as outdated.
This comment was marked as outdated.
|
4 participants
Updates k8s dependencies to 0.27 and controller-runtime to v0.15.
With the update to controller-runtime v0.15 (changes in release detailed here), this PR has following changes to combat the breaking changes:
Changes wrt - https://issues.redhat.com/browse/SANDBOX-559
DO NOT MERGE (All the PRs related to version updates need to be merged at once, but these PR are for early feedback so that there are not a lot of changes to review at once)