Skip to content

Commit

Permalink
ci: fix lint, fmt and upload artifacts (#218)
Browse files Browse the repository at this point in the history
* chore(.github): update actions/upload-artifacts
  • Loading branch information
mafredri authored Nov 8, 2024
1 parent 20367d4 commit 3e5cea5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
env:
COVERALLS_TOKEN: ${{ secrets.github_token }}
- name: Upload coverage.html
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage
path: ci/out/coverage.html
3 changes: 2 additions & 1 deletion ci/fmt.mk
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ modtidy: gen
go mod tidy

gofmt: gen
go run mvdan.cc/gofumpt@latest -w .
# gofumpt v0.7.0 requires Go 1.22 or later.
go run mvdan.cc/[email protected] -w .

prettier:
npx prettier --write --print-width=120 --no-semi --trailing-comma=all --loglevel=warn $$(git ls-files "*.yml")
Expand Down
3 changes: 2 additions & 1 deletion ci/lint.mk
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ govet:
go vet ./...

golint:
go run github.com/golangci/golangci-lint/cmd/golangci-lint@latest run .
# golangci-lint newer than v1.55.2 is not compatible with Go 1.20 when using go run.
go run github.com/golangci/golangci-lint/cmd/[email protected] run .

0 comments on commit 3e5cea5

Please sign in to comment.