Fix Devolutions Auto-Complete #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll give this a test and a review thanks for the contribution! @rhys96 |
matifali
reviewed
Oct 24, 2025
|
I made a few additions since some of the other variables were incorrect based on the descriptions, but everything looks and works great! I think we are good here to merge but I will need someone else to approve since I made some commits 😸 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes auto-complete functionality in the Devolutions Gateway integration and enhances the user experience by hiding UI elements during initial session load, enabling better default settings, and improving session closure behavior. The changes update the module to version 1.3.0.
Key changes include:
- Fixed auto-complete by hiding the
app-net-scancontainer and refactoring form detection logic - Enabled Unicode keyboard mode and dynamic window resizing by default
- Modified the "Close Session" button to close the window instead of returning to the session manager
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| powershell-installation-script.tftpl | Added TLS 1.2 support, PSGallery trust configuration, support for "latest" version, and dynamic module path detection |
| main.tf | Added display_name, slug, and icon variables for customization; changed default Devolutions Gateway version to "latest" |
| main.test.ts | Updated test expectations to reflect new "latest" default version and simplified regex pattern for form field matching |
| devolutions-patch.js | Refactored form detection to use polling instead of mutation observers; added logic to hide app-net-scan, enable default checkboxes, and handle window closure |
| README.md | Updated version references from 1.2.3 to 1.3.0 |
registry/coder/modules/windows-rdp/powershell-installation-script.tftpl
Outdated
Show resolved
Hide resolved
matifali
approved these changes
Oct 28, 2025
ericpaulsen
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I’ve completed a set of modifications to improve the user experience and session behaviour within Devolutions Gateway:
sluganddisplay_nameas input variables.Type of Change
Module Information
Path:
registry/coder/modules/windows-rdpNew version:
v1.3.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
"None"