Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display-language.diff #5317

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Update display-language.diff #5317

merged 2 commits into from
Jul 15, 2022

Conversation

bbbboom
Copy link

@bbbboom bbbboom commented Jul 2, 2022

The requested "vscode-remote-resource" is not under the "{{WORKBENCH_WEB_BASE_URL}}" path, It needs to access the upper level path.

Fixes #

"vscode-remote-resource" not under "{{WORKBENCH_WEB_BASE_URL}}", It needs to access the upper level path.
@bbbboom bbbboom requested a review from a team July 2, 2022 04:18
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and nice find!!

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5317 (73e480b) into main (97af08b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5317   +/-   ##
=======================================
  Coverage   72.47%   72.47%           
=======================================
  Files          30       30           
  Lines        1671     1671           
  Branches      367      367           
=======================================
  Hits         1211     1211           
  Misses        397      397           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97af08b...73e480b. Read the comment docs.

@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 15, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) July 15, 2022 17:24
@jsjoeio jsjoeio merged commit 714257b into coder:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants