Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add support for FreeBSD to the build process #2466

Merged
merged 6 commits into from
Dec 18, 2020
Merged

ci: Add support for FreeBSD to the build process #2466

merged 6 commits into from
Dec 18, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 14, 2020

Updates #1826
Updates #1880
Updates #2320
Updates #2349

@nhooyr nhooyr requested a review from jsjoeio December 14, 2020 23:07
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 14, 2020

Need to fix some other scripts rn as well.

@nhooyr nhooyr removed the request for review from jsjoeio December 14, 2020 23:08
@nhooyr nhooyr marked this pull request as draft December 14, 2020 23:08
@nhooyr nhooyr force-pushed the freebsd-abe7 branch 3 times, most recently from fcdb9a0 to fd79538 Compare December 14, 2020 23:25
@nhooyr nhooyr mentioned this pull request Dec 14, 2020
Closed
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 18, 2020

Now closes #1826, #1880, #2349

I'm going to leave #2320 for now as it needs further investigation.

@nhooyr nhooyr marked this pull request as ready for review December 18, 2020 07:55
@nhooyr nhooyr requested a review from jsjoeio December 18, 2020 07:55
jsjoeio
jsjoeio approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good as usual! 🌮

Only question was about removing electron as a package. If that was intentional, should we also remove lib/vscode/src/typings/electron.d.ts?

lib/vscode/package.json Show resolved Hide resolved
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 18, 2020

@jsjoeio See commit 3

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 18, 2020

@nhooyr got it!

Looks good! 🚀

(side note: would be curious to hear why we should keep the types for my own learning?)

@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 18, 2020

(side note: would be curious to hear why we should keep the types for my own learning?)

VS Code won't compile without it. We still compile the electron parts for some reason. I asked @code-asher and he said the easiest way to avoid problems is just to include the types to quiet tsc.

@nhooyr nhooyr merged commit ea1b387 into master Dec 18, 2020
@nhooyr nhooyr deleted the freebsd-abe7 branch December 18, 2020 18:04
@nhooyr nhooyr added this to the v3.8.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @jsjoeio