Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feature watch recursively is unavailable on the current platform, which is being used to r un Node.js. #1892

Closed
MrLiu0635 opened this issue Jul 21, 2020 · 5 comments · Fixed by #1998
Labels
bug Something isn't working
Milestone

Comments

@MrLiu0635
Copy link

When I run my custom plugin with local VSCode env, It do well. But I run it with code-server, error occur.

【ERROR: The feature watch recursively is unavailable on the current platform, which is being used to r
un Node.js.】

I guess error causes by this problem:
Node v14 introduced a breaking change to the fs.watch() API.
It report and fix have been submitted to filewatch: https://github.com/fgnass/filewatcher/pull/6
TIM截图20200721114722

Web Browser: Chrome
Local OS: Window
Remote OS: Centos 7
Remote Architecture: Docker
code-server --version:
code-server: v3.4.1
VS Code: v1.45.1
Commit: 48f7c27
Date: 2020-06-04T10:39:14Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116
Safari/537.36

Based on I said before, may I have your reply about it.

  1. Node problem do make it error,right?
  2. What I should do now,and What I should do after node problem solved.
@code-asher
Copy link
Member

I think the only workaround right now would be to run code-server with your own version of Node (use 12 since that's what VS Code uses).

It'll depend on where code-server is installed but for example: node /usr/lib/code-server.

For the long term, we'll need to target the same version of Node VS Code does. I'll open an issue for it.

@nhooyr nhooyr added the bug Something isn't working label Jul 21, 2020
nhooyr added a commit that referenced this issue Jul 22, 2020
Closes #1894
Closes #1892
Closes #1810
@MrLiu0635
Copy link
Author

MrLiu0635 commented Jul 27, 2020

Thanks for your reply.

I think your suggestion would work for my question, after I install code-server on newest node version in my local environments.

However, it is a pity, my team is working on docker of code-server.
Shall we have the Dockerfile for reference to build code-server on 12+ node by ourselves? 😄

Or not, we could only try do it ourselves from the beginning.

Looking forward to hearing from you.

@code-asher
Copy link
Member

We'll publish a new version as soon as we can but we've got a PR open which you could use to build it yourself in the meantime: #1904

If you're looking to build your own Docker container then you can follow the build instructions here. We build code-server in a Centos 7 Docker container (Dockerfile here) and then we deploy a Debian container (Dockerfile here).

@MrLiu0635
Copy link
Author

@code-asher How nice you are. 😄

You did a great job. I would try it myself before.

Thank you.

code-asher pushed a commit that referenced this issue Aug 19, 2020
Closes #1894
Closes #1892
Closes #1810
nhooyr added a commit that referenced this issue Aug 25, 2020
Closes #1894
Closes #1892
Closes #1810
nhooyr added a commit that referenced this issue Aug 26, 2020
@nhooyr nhooyr added this to the v3.5.0 milestone Aug 31, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

v3.5.0 with VS Code v1.48.2 has been released, fixing this issue! 🍻

@nhooyr nhooyr closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants