Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user-data-dir and extension-dir in config.yaml #1676

Closed
silenceleaf opened this issue May 19, 2020 · 4 comments · Fixed by #1679
Closed

Allow user-data-dir and extension-dir in config.yaml #1676

silenceleaf opened this issue May 19, 2020 · 4 comments · Fixed by #1679
Assignees
@nhooyr
Labels
bug Something isn't working
Milestone
v3.4.0

Comments

@silenceleaf
Copy link

Everything look good!

I am using the new option --config passing a file to code-server.

looks like user-data-dir and extensions-dir is not read from file.

my config.yaml:

user-data-dir: /home/junyan/mnt/e/Config/code-server/Data/
extensions-dir: /home/junyan/mnt/e/Config/code-server/Extensions/

using command line parameter everything works.
@nhooyr
Copy link
Contributor

nhooyr commented May 19, 2020

Looking into it!

@nhooyr
Copy link
Contributor

nhooyr commented May 19, 2020

Ah got it, thanks for reporting will push fix soon.

@nhooyr nhooyr self-assigned this May 19, 2020
@nhooyr nhooyr added the bug Something isn't working label May 19, 2020
@nhooyr nhooyr changed the title 3.3.1 load config from config.yaml Allow user-data-dir and extension-dir in config.yaml May 19, 2020
nhooyr added a commit that referenced this issue May 19, 2020
@nhooyr
Allow user-data-dir and extension-dir in config.yaml
183d9f9 
Closes #1676
@nhooyr nhooyr mentioned this issue May 19, 2020
Merged
nhooyr added a commit that referenced this issue May 19, 2020
@nhooyr
Allow user-data-dir and extension-dir in config.yaml
8053ec6 
Closes #1676
@nhooyr nhooyr added this to the v3.3.2 milestone May 19, 2020
@nhooyr nhooyr mentioned this issue May 22, 2020
Closed
@nhooyr nhooyr modified the milestones: v3.3.2, v3.4.0 May 27, 2020
@ssnjr2002
Copy link

Hate to bring this back but I still face this issue on v3.4.0

@nhooyr
Copy link
Contributor

nhooyr commented Jun 4, 2020

Yup, see release notes in #1766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

Allow user-data-dir and extension-dir in config.yaml coder/code-server
3 participants
@silenceleaf @nhooyr @ssnjr2002