Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.0: Accessing from windows is broken #1642

Closed
eugenechyrski opened this issue May 15, 2020 · 5 comments · Fixed by #1670 or #1672
Closed

v3.3.0: Accessing from windows is broken #1642

eugenechyrski opened this issue May 15, 2020 · 5 comments · Fixed by #1670 or #1672
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eugenechyrski
Copy link

Hi looks like latest build changes broke path separator.

  1. Host machine windows
  2. code-server machine linux in docker
  3. Relevant docker part
RUN go get github.com/derekparker/delve/cmd/dlv
RUN git clone https://github.com/cdr/code-server.git
WORKDIR code-server
RUN git submodule update --init
RUN yarn
RUN yarn vscode
RUN yarn build
RUN yarn build:vscode
RUN yarn release
WORKDIR release
RUN yarn --production
WORKDIR /
ENTRYPOINT node /code-server/release --disable-telemetry  --host 0.0.0.0 --port 3003 

code server is up and running in docker and accessible via 127.0.0.1:3003 on windows host .

Following request fails while ui is loading in browser
http://127.0.0.1:3003/vscode-remote-resource?path=%5Ccode-server%5Crelease%5Clib%5Cvscode%5Cextensions%5Ctheme-defaults%5Cthemes%5Cdark_plus.json&tkn=

Checked and confirmed that file is there.
changin request to http://127.0.0.1:3003/vscode-remote-resource?path=/code-server/release/lib/vscode/extensions/theme-defaults/themes/dark_plus.json&tkn=
returns json data.

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

Thanks for reporting we'll look into this.

@nhooyr nhooyr added the bug Something isn't working label May 18, 2020
@asomethings
Copy link

asomethings commented May 18, 2020

For any windows users using code-server with chrome. Sharing an requestly extension config for replacing backslash to foward slash.

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

Will publish a 3.3.1 in the next few hours, just working on #1667

@nhooyr nhooyr added this to the v3.3.1 milestone May 18, 2020
@eugenechyrski
Copy link
Author

Thank you, now it works fine!

nhooyr added a commit that referenced this issue May 18, 2020
This release fixes bugs introduced with the release of v3.3.0

- We've reverted to VS Code 1.45.1 due to bugs in 1.46 #1667
- Accessing code-server from a web browser on Windows has been fixed #1642
- Search in project has been fixed #1665
- The glibc requirement on static releases has been lowered to v2.19 #1656
@nhooyr nhooyr mentioned this issue May 18, 2020
@nhooyr nhooyr pinned this issue May 19, 2020
@nhooyr nhooyr changed the title Accessing from windows is broken v3.3.0: Accessing from windows is broken May 19, 2020
@nhooyr
Copy link
Contributor

nhooyr commented May 19, 2020

https://github.com/cdr/code-server/releases/tag/v3.3.1

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants