🤖 Fix workspace recency after compaction #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
approved these changes
Oct 13, 2025
ammar-agent
force-pushed
the
fix-workspace-recency-compaction
branch
from
36c235e to
9d21280
Compare
|
E2E test failure appears to be a known flaky test ("Projects" navigation not visible). Multiple recent PRs (#228, #226, #222) are hitting the same issue. My changes only affect workspace recency calculation in Static checks, unit tests, and integration tests all pass. ✅ Requesting manual review to assess if merge is appropriate despite flaky E2E. |
When chat history is compacted, user messages are replaced with a summary (assistant message with compacted=true). The recency calculation only checked for user messages, causing compacted workspaces to sink to the bottom. Changes: - Rename WorkspaceState.lastUserMessageAt → recencyTimestamp (clearer semantics) - Add fallback: if no user messages, use most recent compacted message timestamp - Keeps Date.now() for new compaction summaries (workspace jumps to top, correct UX) This ensures workspaces with only compacted history maintain their position in the sidebar, while still preferring user messages during active streams. Generated with `cmux`
ammar-agent
force-pushed
the
fix-workspace-recency-compaction
branch
from
9d21280 to
14ac208
Compare
ammar-agent
added a commit
that referenced
this pull request
Oct 13, 2025
Adapt to property rename from lastUserMessageAt to recencyTimestamp in WorkspaceState (from PR #229). _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After compaction, workspaces would drop to the bottom of the sidebar list. This happened because recency calculation only checked for user messages, and compaction replaces chat history with a summary (assistant message with
compacted: true).Solution
Updated recency calculation to use a fallback:
The compaction summary continues to use
Date.now()as its timestamp, so workspaces jump to the top after compaction (correct UX, since it's active usage).Changes
WorkspaceState.lastUserMessageAt→recencyTimestampfor clearer semanticsTesting
make typecheckpassesmake testpasses (409 pass, 1 skip, 0 fail)Generated with
cmux