Fix use of context malloc in VM creation. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first malloc call that allocates the VM structure was passed a null VM and so crashed on attempting to access is context field. This is hidden in uses that don't use the context malloc because the compiler will remove the dead load.
|
FYI: We now have enough plumbing in CHERIoT RTOS to use this feature and have separate quotas for different JavaScript heaps that use Microvium, with the code shared. With this fix, it all works. |
|
Thanks. That makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first malloc call that allocates the VM structure was passed a null VM and so crashed on attempting to access is context field. This is hidden in uses that don't use the context malloc because the compiler will remove the dead load.