Include empty end lines in Text.iterLines

FIX: Fix a bug that caused `Text.iterLines` to not return empty lines at the end of the iterated ranges. Closes codemirror/dev#1295
codemirror · Nov 10, 2023 · 0f61d04 · 0f61d04
1 parent a14b093
commit 0f61d04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/text.ts b/src/text.ts
@@ -518,7 +518,10 @@ class LineCursor implements TextIterator {
 
   next(skip = 0) {
     let {done, lineBreak, value} = this.inner.next(skip)
-    if (done) {
+    if (done && this.afterBreak) {
+      this.value = ""
+      this.afterBreak = false
+    } else if (done) {
       this.done = true
       this.value = ""
     } else if (lineBreak) {

diff --git a/test/test-text.ts b/test/test-text.ts
@@ -177,7 +177,8 @@ describe("Text", () => {
     ist(get(), "ab\ncde\n\n\nf\n\ng")
     ist(get(1, doc.lines + 1), "ab\ncde\n\n\nf\n\ng")
     ist(get(2, 3), "cde")
-    ist(get(1, 1), "")
+    ist(get(2, 3), "cde")
+    ist(get(1, 5), "ab\ncde\n\n")
     ist(get(2, 1), "")
     ist(get(3), "\n\nf\n\ng")
   })