Fix JSHint error and minor code improvements #6729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JSHint option error since v5.62.0 by deep cloning `state.options` and removing `highlightLines` before passing to JSHint - lines 154-155 Cache `highlightLines` value outside the loop - line 183, 215 Remove `isHighlightErrorLinesEnabled()` since it is used only twice and has a static value - lines 80, 183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSHint option error since v5.62.0 by deep cloning
state.optionsand removinghighlightLinesbefore passing to JSHintCache
highlightLinesvalue outside the loopRemove
isHighlightErrorLinesEnabled()since it is only used twice and has a static value