Fix white CodeMirror-scrollbar-filler on dark themes #6485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
background-color: white; remains white on dark themes which doesn't suit dark background pages. Changing it to transparent to match the theme.
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Feb 23, 2021
Let's locally revert this change for now and wait for CodeMirror to fix the issue upstream. I have tried using `inherit` and `initial`, but both don't work. Since we have a separate darkmode file, we can safely add the white background back, as in darkmode the other CSS file is loaded. This was originally applied in CodeMirror in codemirror/codemirror5#6485 [email protected] Fixed: 1180740 Change-Id: Ia48e3f46ec9e57a2104d30bd9fed523dac1ddf10 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2714547 Commit-Queue: Tim van der Lippe <[email protected]> Commit-Queue: Jack Franklin <[email protected]> Auto-Submit: Tim van der Lippe <[email protected]> Reviewed-by: Jack Franklin <[email protected]>
Member
|
Reverted, see #6599 |
erosman
added a commit
to erosman/CodeMirror
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background-color: white; remains white on dark themes which doesn't suit dark background pages. Changing it to transparent to match the theme.