Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment plugin doesn't work #1975

Closed
aslushnikov opened this issue Nov 22, 2013 · 2 comments
Closed

Comment plugin doesn't work #1975

aslushnikov opened this issue Nov 22, 2013 · 2 comments

Comments

@aslushnikov
Copy link
Contributor

Try to comment the following line

console.log("//string gets corrupted.");

This results in

console.log("string gets corrupted.");

instead of

//console.log("//string gets corrupted.");
@aslushnikov
Copy link
Contributor Author

Thank you for this patch.
Still, doesn't work for the following case:

console.log("/*string gets corrupted.*/");

marijnh added a commit that referenced this issue Dec 9, 2013
To make sure it isn't seeing comments that are actually
strings.

Issue #1975
@marijnh
Copy link
Member

marijnh commented Dec 9, 2013

Indeed. Should be better with attached patch.

anaran pushed a commit to anaran/CodeMirror that referenced this issue Feb 22, 2014
anaran pushed a commit to anaran/CodeMirror that referenced this issue Feb 22, 2014
To make sure it isn't seeing comments that are actually
strings.

Issue codemirror#1975
davidfstr added a commit to techsmartkids/codemirror5 that referenced this issue Apr 22, 2024
davidfstr added a commit to techsmartkids/codemirror5 that referenced this issue Apr 23, 2024
marijnh pushed a commit that referenced this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants