This repository has been archived by the owner on May 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge for errors callback: order of the params was incorrect
I just checked it in a loop opening some of the URLs I had problems with. Works great so far. |
@codemanki thanks for giving it a try. I will soon publish this version |
@Ekliptor done. Could you please check it once again? Now it only allows max 3 challenges |
codemanki
changed the title
[WIP] Support recursive challenge solving
Support recursive challenge solving
Dec 9, 2018
thanks for your very thorough work and fast responses. We are using it in production since Monday and working great so far ;) |
ghost
mentioned this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #65
What has been done:
followAllRedirects
flag from the request librarycallback(.., body, response);
instead ofreturn callback(..., response, body);
What yet to be done: