Update Sucuri WAF Solving

[ghost]

See #240

[ghost]

If merging this, please merge #243 first, I'll fix the conflicts here.

[codemanki]

Looks excellent to me!

[codemanki]

Thank you :)

[ghost]

Yw and Thank you @codemanki,

🤔 I thought there would be a conflict.

This PR is missing the fix from #243. One test like this isn't a big deal whereas before almost all of them had this problem. So we can ignore this for now if desired.

The problem is with the promise resolving and calling done even if the test errors. The solution was to move the following code into the callback so any errors would prevent done being called. Otherwise, the test can both pass and fail.

cloudscraper/test/test-index.js

Line 452 in 678fe70

expect(promise).to.eventually.equal(requestedPage).and.notify(done);

Buggy:

cloudscraper/test/test-index.js

Lines 442 to 453 in 678fe70

	const promise = cloudscraper.get(options, function (error, response, body) {
	expect(error).to.be.null;
	expect(Request).to.be.calledTwice;
	expect(Request.firstCall).to.be.calledWithExactly(helper.defaultParams);
	expect(Request.secondCall).to.be.calledWithExactly(expectedParams);
	expect(body).to.be.equal(requestedPage);
	});
	expect(promise).to.eventually.equal(requestedPage).and.notify(done);
	});

Fixed:

cloudscraper/test/test-index.js

Lines 470 to 480 in 678fe70

	const promise = cloudscraper.get(options, function (error, response, body) {
	expect(error).to.be.null;
	expect(Request).to.be.calledTwice;
	expect(Request.firstCall).to.be.calledWithExactly(helper.defaultParams);
	expect(Request.secondCall).to.be.calledWithExactly(expectedParams);
	expect(body).to.be.equal(requestedPage);
	expect(promise).to.eventually.equal(requestedPage).and.notify(done);
	});
	});