Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss page contents space fix #450

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

darthleslin
Copy link

  1. Increased little bit of line height for the lines in the paragraph.
  2. Discuss page break tags removed and padding increased.
  3. space between the inner-text-box increased to 32px to maintain the uniformity between inside and outside of the wrappers.

@kenjis
Copy link
Contributor

kenjis commented May 27, 2024

Can you show the screenshots before and after?

@darthleslin
Copy link
Author

BEFORE
before

AFTER
after

@kenjis

@kenjis
Copy link
Contributor

kenjis commented May 30, 2024

Thank you!
But your git commit is not verified.
Can you upload your public key to GitHub?
Screenshot 2024-05-30 11 48 27

@darthleslin
Copy link
Author

Thank you! But your git commit is not verified. Can you upload your public key to GitHub? Screenshot 2024-05-30 11 48 27

Done.
Thank You.

Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this attention to detail! The only part I don't prefer is the bullet spacing feels too large (though I do agree a bit more space is warranted). But if others are in favor it's just an opinion.

@kenjis kenjis merged commit 22b7f25 into codeigniter4projects:develop Jun 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants