Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devkit #348

Merged
merged 9 commits into from
Dec 25, 2022
Merged

Update devkit #348

merged 9 commits into from
Dec 25, 2022

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Dec 23, 2022 •
edited
Loading

Fixes #333

@kenjis
chore: composer update
63ed9ad
@kenjis
style: run php-cs-fixer
bedf121
@kenjis
chore: update php-cs-fixer commands in composer.json
776d567
@kenjis
chore: update .php-cs-fixer.dist.php
120584f
@kenjis
chore: update rector.php
ad5bccb
@kenjis
test: refactor by rector
277316d
@kenjis
refactor: workaround for PHPStan errors
4164f4c 
 ------ -------------------------------------------------------------------------------------
  Line   app/Libraries/Blog.php
 ------ -------------------------------------------------------------------------------------
  253    Negated boolean expression is always true.
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting
         treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.
  255    Negated boolean expression is always false.
  262    Negated boolean expression is always true.
  269    Unreachable statement - code above always terminates.
 ------ -------------------------------------------------------------------------------------
@coveralls
Copy link

coveralls commented Dec 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3762475011

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%
Totals Coverage Status
Change from base Build 3762143062: 0.0%
Covered Lines: 243
Relevant Lines: 329
💛 - Coveralls

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 23, 2022
MGatner
MGatner approved these changes Dec 24, 2022
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit cefcc6f into codeigniter4projects:develop Dec 25, 2022
@kenjis kenjis deleted the update-devkit branch December 25, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infection develop fails
4 participants
@kenjis @coveralls @MGatner @Arhell