Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop PHP 7.3 support #30

Merged
merged 1 commit into from
Apr 2, 2022
Merged

chore: drop PHP 7.3 support #30

merged 1 commit into from
Apr 2, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 1, 2022

No description provided.

@kenjis kenjis marked this pull request as draft April 1, 2022 00:13
@kenjis kenjis added the github_actions Pull requests that update GitHub Actions code label Apr 1, 2022
@kenjis kenjis marked this pull request as ready for review April 1, 2022 00:15
MGatner
MGatner approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. This library should implement the CodeIgniter Dev Kit and switch to codeigniter4/framework eventually, but I don't think anyone is working on it right now.

@MGatner
Copy link
Member

MGatner commented Apr 2, 2022

Coveralls failures are acceptable.

@kenjis kenjis merged commit 4e31d9a into codeigniter4:develop Apr 2, 2022
@kenjis kenjis deleted the drop-php73 branch April 2, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner