Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto_link() include trailing slashes #9167

Conversation

corenominal
Copy link

@corenominal corenominal commented Sep 3, 2024

Description
Fixes: #9165
Adjusted regular expression to include trailing slash.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the tests needed Pull requests that need tests label Sep 4, 2024
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Sep 4, 2024
@kenjis
Copy link
Member

kenjis commented Sep 5, 2024

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

@kenjis
Copy link
Member

kenjis commented Sep 5, 2024

  1. Please sign all commits.
  2. Add test code that proves the code works.
  3. We do not use merge commits in PR branches. Please remove the merge commits. Use git rebase instead of git merge.

@kenjis kenjis mentioned this pull request Sep 5, 2024
5 tasks
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 5, 2024
Copy link

github-actions bot commented Sep 6, 2024

👋 Hi, @corenominal!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label Sep 6, 2024
@kenjis
Copy link
Member

kenjis commented Sep 6, 2024

Closed by #9169

@kenjis kenjis closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them GPG-Signing needed Pull requests that need GPG-Signing stale Pull requests with conflicts tests needed Pull requests that need tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: auto_link() fails to include trailing slashes in URLs
3 participants