Skip to content

docs: fix doc comments for Router #9151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2024
Merged

docs: fix doc comments for Router #9151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3324e7
docs: fix doc comment
kenjis Aug 27, 2024
679ba59
docs: make comments more precise
kenjis Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions system/Router/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function __construct(RouteCollectionInterface $routes, ?Request $request
}

/**
* Finds the controller method corresponding to the URI.
* Finds the controller corresponding to the URI.
*
* @param string|null $uri URI path relative to baseURL
*
Expand Down Expand Up @@ -241,7 +241,7 @@ public function getFilters(): array
}

/**
* Returns the name of the matched controller.
* Returns the name of the matched controller or closure.
*
* @return (Closure(mixed...): (ResponseInterface|string|void))|string Controller classname or Closure
*/
Expand All @@ -254,7 +254,7 @@ public function controllerName()

/**
* Returns the name of the method to run in the
* chosen container.
* chosen controller.
*/
public function methodName(): string
{
Expand Down