Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filters passed to the $routes->group() are not merged into the filters passed to the inner routes #9064

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 23, 2024

Description
Fixes #9063

$routes->group('', ['filter' => ['csrf']], static function ($routes) {
    $routes->get('getuserinfo', 'Mmeber::getUserInfo', ['filter' => ['honeypot']]);
});

Before:

+--------+-------------+------+--------------------------------------+----------------+---------------+
| Method | Route       | Name | Handler                              | Before Filters | After Filters |
+--------+-------------+------+--------------------------------------+----------------+---------------+
| GET    | getuserinfo | »    | \App\Controllers\Mmeber::getUserInfo | honeypot       | honeypot      |
+--------+-------------+------+--------------------------------------+----------------+---------------+

After:

+--------+-------------+------+--------------------------------------+----------------+---------------+
| Method | Route       | Name | Handler                              | Before Filters | After Filters |
+--------+-------------+------+--------------------------------------+----------------+---------------+
| GET    | getuserinfo | »    | \App\Controllers\Mmeber::getUserInfo | csrf honeypot  | honeypot csrf |
+--------+-------------+------+--------------------------------------+----------------+---------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 23, 2024
@kenjis kenjis merged commit f18b8f2 into codeigniter4:develop Jul 26, 2024
42 checks passed
@kenjis kenjis deleted the fix-route-group-filters branch July 26, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Routing groups and in-group routes use filters that are only effective within the group.
4 participants