New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return and param types of BaseConnection #8983

Merged

paulbalandan merged 1 commit into codeigniter4:develop from paulbalandan:connection-types

Jun 22, 2024

+32 −79

Member

paulbalandan commented Jun 21, 2024

Description

Make return types a little precise.
Fixed a param type of MockConnection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


          fix: return and param types of BaseConnection

abfcba7

kenjis approved these changes

View reviewed changes

kenjis added the bug label

michalsn approved these changes

View reviewed changes

paulbalandan merged commit 4e68814 into codeigniter4:develop

41 checks passed

paulbalandan deleted the connection-types branch

June 22, 2024 10:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment