Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Resolved phpstan error in Config/Filters.php #8854

Merged
merged 1 commit into from
May 5, 2024

Conversation

sahilKhatik
Copy link
Contributor

@sahilKhatik sahilKhatik commented May 5, 2024

Description
See #8732

Added doc comment in system/Config/Filters.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@sahilKhatik
Copy link
Contributor Author

Hi, I have made a small change to know if it is the correct way to contribute to this project, please let me know if my contribution adhered to policies and standards.

@kenjis kenjis changed the title refactor: Resolved phpstan error in Config/Filters.php docs: Resolved phpstan error in Config/Filters.php May 5, 2024
@ddevsr ddevsr added the documentation Pull requests for documentation only label May 5, 2024
@kenjis kenjis merged commit fd9cb65 into codeigniter4:develop May 5, 2024
40 checks passed
@kenjis
Copy link
Member

kenjis commented May 5, 2024

@sahilKhatik Thank you. There is no big problem in this PR!

We have the documentation for PRs. Check this if you have questions.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants