Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spark config:check detects Config Caching #8711

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 5, 2024

Description

  • spark config:check detects Config Caching.
  • it shows Config Caching state at the bottom.
$ php spark config:check Security

CodeIgniter v4.4.7 Command Line Tool - Server Time: 2024-04-05 00:14:18 UTC+00:00

Config\Security#32 (9) (
    public 'csrfProtection' -> string (6) "cookie"
    public 'tokenRandomize' -> boolean false
    public 'tokenName' -> string (14) "csrf_test_name"
    public 'headerName' -> string (12) "X-CSRF-TOKEN"
    public 'cookieName' -> string (16) "csrf_cookie_name"
    public 'expires' -> integer 7200
    public 'regenerate' -> boolean true
    public 'redirect' -> boolean false
    public 'samesite' -> string (3) "Lax"
)

Config Caching: Disabled

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Apr 5, 2024
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add this to the command description. Information on how to change the cache status should also be added.

@kenjis kenjis force-pushed the feat-config-check-shows-config-cache branch from dde8a60 to 6b80f3d Compare April 5, 2024 07:52
@kenjis
Copy link
Member Author

kenjis commented Apr 5, 2024

Updated the docs.

@kenjis kenjis changed the title feat: spark config:check ditects Config Caching feat: spark config:check detects Config Caching Apr 5, 2024
@kenjis kenjis merged commit 0cab3e5 into codeigniter4:4.5 Apr 5, 2024
40 checks passed
@kenjis kenjis deleted the feat-config-check-shows-config-cache branch April 5, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants