Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docstring on TestResponse.assertNotOk() #8585

Merged
merged 1 commit into from
Feb 26, 2024
Merged

docs: fix docstring on TestResponse.assertNotOk() #8585

merged 1 commit into from
Feb 26, 2024

Conversation

rahmatnazali
Copy link
Contributor

Description

The docstring for TestResponse.assertNotOk() method seems to be copied from assertOK() and left unchanged.
In this PR I'm proposing small change to fix it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (no code added/changed)
  • Unit testing, with >80% coverage (no code added/changed)
  • User guide updated (no code added/changed)
  • Conforms to style guide

The docstring for said method seems to be copied from `assertOK()` and left unchanged.
@ddevsr ddevsr added the documentation Pull requests for documentation only label Feb 26, 2024
@ddevsr ddevsr requested a review from kenjis February 26, 2024 04:06
@kenjis kenjis changed the title fix: docstring on TestResponse.assertNotOk() docs: fix docstring on TestResponse.assertNotOk() Feb 26, 2024
@kenjis kenjis merged commit 8d281e2 into codeigniter4:develop Feb 26, 2024
62 checks passed
@kenjis
Copy link
Member

kenjis commented Feb 26, 2024

@rahmatnazali Thank you!

@rahmatnazali rahmatnazali deleted the patch-1 branch February 26, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants